jongmin-chung commented on code in PR #7644:
URL: https://github.com/apache/incubator-seata/pull/7644#discussion_r2366686561
##########
tm/src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java:
##########
@@ -290,7 +290,7 @@ private void rollbackTransaction(GlobalTransaction tx,
Throwable originalExcepti
break;
case TimeoutRollbacked:
case Rollbacked:
- // rollback transactions but do not exist are usually
considered completed
+ // rollback transactions but do not exist are usually considered
completed
Review Comment:
### Java 11 (Has Error ❌)
```shell
$ sdk use java 11.0.27-librca
$ ./mvnw spotless:check
[ERROR] Failed to execute goal
com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on
project seata-tm: The following files had format violations:
[ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java
[ERROR] @@ -290,7 +290,7 @@
[ERROR] ················break;
[ERROR] ············case·TimeoutRollbacked:
[ERROR] ············case·Rollbacked:
[ERROR]
-············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR]
+················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] ············case·Finished:
[ERROR]
················code·=·TransactionalExecutor.Code.RollbackDone;
[ERROR] ················break;
[ERROR] Run 'mvn spotless:apply' to fix these violations.
```
### Java 17 and above (✅)
```shell
$ sdk use java 17.0.16-librca (java 21, java 25 OK)
$ ./mvnw spotless:check
[ERROR] Failed to execute goal
com.diffplug.spotless:spotless-maven-plugin:2.44.3:check (default-cli) on
project seata-tm: The following files had format violations:
[ERROR] src/main/java/org/apache/seata/tm/api/TransactionalTemplate.java
[ERROR] @@ -290,7 +290,7 @@
[ERROR] ················break;
[ERROR] ············case·TimeoutRollbacked:
[ERROR] ············case·Rollbacked:
[ERROR]
-················//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR]
+············//·rollback·transactions·but·do·not·exist·are·usually·considered·completed
[ERROR] ············case·Finished:
[ERROR]
················code·=·TransactionalExecutor.Code.RollbackDone;
[ERROR] ················break;
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn <args> -rf :seata-tm
```
This is the situation above, so there's no problem starting with Java 17 or
later.
I have a problem with Java 11. And this happens unconditionally because the
position of the comment changes.
What should I do in this situation? ([In CI, Java 17 is
set](https://github.com/apache/incubator-seata/blob/2.x/.github/workflows/spotless-check.yml#L35-L39),
so there is no problem.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
