maple525866 opened a new pull request, #7662:
URL: https://github.com/apache/incubator-seata/pull/7662
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
#7585
With the help of @funky-eyes's analysis, I think it is not a network or port
problem, but a visibility problem.
Because the rm member variable in RmClientTest is not declared as volatile,
this may cause the rm variable to be modified multiple times during concurrent
testing, thus causing this problem。
Here is the fix I made for the problem:
- The volatile keyword ensures that writes to the rm variable are
immediately visible to all threads, preventing instruction reordering.
- Test ordering: The @TestMethodOrder and @Order annotations ensure that
tests are executed sequentially, avoiding concurrent access issues.
- Double-checked locking safety: volatile + synchronized ensures thread-safe
lazy loading.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #7558
### Ⅲ. Why don't you add test cases (unit test/integration test)?
### Ⅳ. Describe how to verify it
mvn clean test
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
