This is an automated email from the ASF dual-hosted git repository.
alexstocks pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-seata-go.git
The following commit(s) were added to refs/heads/master by this push:
new a1816a93 optimize: fix go vet issue (#892)
a1816a93 is described below
commit a1816a93e07761099f7ca597cced1f8bae9587d3
Author: jimin <[email protected]>
AuthorDate: Sun Sep 28 09:46:22 2025 +0800
optimize: fix go vet issue (#892)
fix go vet
Co-authored-by: FengZhang <[email protected]>
---
pkg/datasource/sql/datasource/base/meta_cache_test.go | 4 ----
pkg/datasource/sql/exec/at/base_executor_test.go | 10 +++++-----
pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go | 10 +++++-----
3 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/pkg/datasource/sql/datasource/base/meta_cache_test.go
b/pkg/datasource/sql/datasource/base/meta_cache_test.go
index 92a7550c..7892160a 100644
--- a/pkg/datasource/sql/datasource/base/meta_cache_test.go
+++ b/pkg/datasource/sql/datasource/base/meta_cache_test.go
@@ -73,7 +73,6 @@ func (m *mockTrigger) LoadAll(ctx context.Context, dbName
string, conn *sql.Conn
func TestBaseTableMetaCache_refresh(t *testing.T) {
type fields struct {
- lock sync.RWMutex
expireDuration time.Duration
capity int32
size int32
@@ -96,7 +95,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
{
name: "test1",
fields: fields{
- lock: sync.RWMutex{},
capity: capacity,
size: 0,
expireDuration: EexpireTime,
@@ -117,7 +115,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
{
name: "test2",
fields: fields{
- lock: sync.RWMutex{},
capity: capacity,
size: 0,
expireDuration: EexpireTime,
@@ -154,7 +151,6 @@ func TestBaseTableMetaCache_refresh(t *testing.T) {
defer loadAllStub.Reset()
c := &BaseTableMetaCache{
- lock: tt.fields.lock,
expireDuration: tt.fields.expireDuration,
capity: tt.fields.capity,
size: tt.fields.size,
diff --git a/pkg/datasource/sql/exec/at/base_executor_test.go
b/pkg/datasource/sql/exec/at/base_executor_test.go
index dd427aa8..432ca0aa 100644
--- a/pkg/datasource/sql/exec/at/base_executor_test.go
+++ b/pkg/datasource/sql/exec/at/base_executor_test.go
@@ -67,8 +67,8 @@ func TestBaseExecBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test_name",
Rows: []types.RowImage{
-
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId",
"user1")}},
-
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId",
"user2")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId",
"user1")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId",
"user2")}},
},
},
"TEST_NAME:1_user1,2_user2",
@@ -84,9 +84,9 @@ func TestBaseExecBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test2_name",
Rows: []types.RowImage{
-
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"),
getColumnImage("age", "11")}},
-
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"),
getColumnImage("age", "22")}},
-
{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId",
"three"), getColumnImage("age", "33")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"),
getColumnImage("age", "11")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"),
getColumnImage("age", "22")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"),
getColumnImage("age", "33")}},
},
},
"TEST2_NAME:1_one_11,2_two_22,3_three_33",
diff --git a/pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go
b/pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go
index 51ab7dd2..8e2f4b12 100644
--- a/pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go
+++ b/pkg/datasource/sql/undo/builder/basic_undo_log_builder_test.go
@@ -93,8 +93,8 @@ func TestBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test_name",
Rows: []types.RowImage{
-
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
-
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two")}},
},
},
"TEST_NAME:1_one,2_two",
@@ -110,9 +110,9 @@ func TestBuildLockKey(t *testing.T) {
types.RecordImage{
TableName: "test2_name",
Rows: []types.RowImage{
-
{[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"),
getColumnImage("age", "11")}},
-
{[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"),
getColumnImage("age", "22")}},
-
{[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId",
"three"), getColumnImage("age", "33")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 1), getColumnImage("userId", "one"),
getColumnImage("age", "11")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 2), getColumnImage("userId", "two"),
getColumnImage("age", "22")}},
+ {Columns:
[]types.ColumnImage{getColumnImage("id", 3), getColumnImage("userId", "three"),
getColumnImage("age", "33")}},
},
},
"TEST2_NAME:1_one_11,2_two_22,3_three_33",
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
