maple525866 opened a new pull request, #7675:
URL: https://github.com/apache/incubator-seata/pull/7675
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [ ] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
1. Problem Background
Seata cannot support Oracle's INSERT ALL batch insert statements. For
example, `insert all into a (id) values(1) into a (id) values(2) SELECT 1 FROM
DUAL` will be parsed as `OracleMultiInsertStatement`, but
`DruidSQLRecognizerFactoryImpl` does not support this statement type.
2. Solution
- Extend `DruidSQLRecognizerFactoryImpl` to add support for
`OracleMultiInsertStatement`
- Extend `OracleOperateRecognizerHolder` to add methods specifically for
handling multiple inserts
- Create `OracleMultiInsertRecognizer` and use `ast.getEntries()` to obtain
insert items. It supports parsing multiple INSERT INTO clauses and correctly
handles various data types (NULL, parameter placeholders, sequences, etc.)
3. Verification Functionality -> Created OracleMultiInsertRecognizerTest
containing 11 test cases:
- Basic functional testing: SQL type, table name, table alias
- Column processing testing: Insert column retrieval, empty column detection
- Data row testing: Basic data, NULL values, parameter placeholders, primary
key processing
- Complex scenario testing: Multi-table inserts, complex statements, edge
cases
- Interface consistency testing: Ensures compliance with the Seata interface
specification
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #7607
### Ⅲ. Why don't you add test cases (unit test/integration test)?
UT have been added
### Ⅳ. Describe how to verify it
mvn clean test
### Ⅴ. Special notes for reviews
Currently, only single-table Oracle INSERT batching is supported. I don't
believe multi-table support is necessary because branching transactions can be
useful.❤️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
