Copilot commented on code in PR #7777: URL: https://github.com/apache/incubator-seata/pull/7777#discussion_r2516930167
########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(choiceParser, "ChoiceStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(failEndParser, "FailEndStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect parameter order. The first parameter should be the object to check for null, not the message. It should be: ```java assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` ########## saga/seata-saga-statelang/src/test/java/org/apache/seata/saga/statelang/parser/StateParserFactoryTest.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.seata.saga.statelang.parser; + +import org.apache.seata.saga.statelang.domain.StateType; +import org.apache.seata.saga.statelang.parser.impl.ChoiceStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensateSubStateMachineStateParser; +import org.apache.seata.saga.statelang.parser.impl.CompensationTriggerStateParser; +import org.apache.seata.saga.statelang.parser.impl.FailEndStateParser; +import org.apache.seata.saga.statelang.parser.impl.ScriptTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.ServiceTaskStateParser; +import org.apache.seata.saga.statelang.parser.impl.SubStateMachineParser; +import org.apache.seata.saga.statelang.parser.impl.SucceedEndStateParser; +import org.junit.jupiter.api.Test; + +import static org.junit.jupiter.api.Assertions.assertNotNull; +import static org.junit.jupiter.api.Assertions.assertTrue; + +/** + * test StateParserFactory + */ +public class StateParserFactoryTest { + + @Test + public void testGetStateParser_ExistingTypes() { + StateParser serviceTaskParser = StateParserFactory.getStateParser(StateType.SERVICE_TASK); + assertNotNull("ServiceTaskStateParser should not be null"); + assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); + + StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); + assertNotNull("ChoiceStateParser should not be null", String.valueOf(choiceParser)); + assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); + + StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); + assertNotNull("CompensationTriggerStateParser should not be null", String.valueOf(compensationTriggerParser)); + assertTrue( + compensationTriggerParser instanceof CompensationTriggerStateParser, + "Parser should be CompensationTriggerStateParser"); + + StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); + assertNotNull("FailEndStateParser should not be null", String.valueOf(failEndParser)); + assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); + + StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); + assertNotNull("SucceedEndStateParser should not be null", String.valueOf(succeedEndParser)); + assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); + + StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); + assertNotNull("SubStateMachineParser should not be null", String.valueOf(subStateMachineParser)); + assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); + + StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); + assertNotNull("CompensateSubStateMachineStateParser should not be null", String.valueOf(subCompensationParser)); + assertTrue( + subCompensationParser instanceof CompensateSubStateMachineStateParser, + "Parser should be CompensateSubStateMachineStateParser"); + + StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); + assertNotNull("ScriptTaskStateParser should not be null", String.valueOf(scriptTaskParser)); Review Comment: The `assertNotNull` call has incorrect usage. It's checking a string representation instead of the actual parser object. It should be: ```java assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); ``` ```suggestion assertNotNull(serviceTaskParser, "ServiceTaskStateParser should not be null"); assertTrue(serviceTaskParser instanceof ServiceTaskStateParser, "Parser should be ServiceTaskStateParser"); StateParser choiceParser = StateParserFactory.getStateParser(StateType.CHOICE); assertNotNull(choiceParser, "ChoiceStateParser should not be null"); assertTrue(choiceParser instanceof ChoiceStateParser, "Parser should be ChoiceStateParser"); StateParser compensationTriggerParser = StateParserFactory.getStateParser(StateType.COMPENSATION_TRIGGER); assertNotNull(compensationTriggerParser, "CompensationTriggerStateParser should not be null"); assertTrue( compensationTriggerParser instanceof CompensationTriggerStateParser, "Parser should be CompensationTriggerStateParser"); StateParser failEndParser = StateParserFactory.getStateParser(StateType.FAIL); assertNotNull(failEndParser, "FailEndStateParser should not be null"); assertTrue(failEndParser instanceof FailEndStateParser, "Parser should be FailEndStateParser"); StateParser succeedEndParser = StateParserFactory.getStateParser(StateType.SUCCEED); assertNotNull(succeedEndParser, "SucceedEndStateParser should not be null"); assertTrue(succeedEndParser instanceof SucceedEndStateParser, "Parser should be SucceedEndStateParser"); StateParser subStateMachineParser = StateParserFactory.getStateParser(StateType.SUB_STATE_MACHINE); assertNotNull(subStateMachineParser, "SubStateMachineParser should not be null"); assertTrue(subStateMachineParser instanceof SubStateMachineParser, "Parser should be SubStateMachineParser"); StateParser subCompensationParser = StateParserFactory.getStateParser(StateType.SUB_MACHINE_COMPENSATION); assertNotNull(subCompensationParser, "CompensateSubStateMachineStateParser should not be null"); assertTrue( subCompensationParser instanceof CompensateSubStateMachineStateParser, "Parser should be CompensateSubStateMachineStateParser"); StateParser scriptTaskParser = StateParserFactory.getStateParser(StateType.SCRIPT_TASK); assertNotNull(scriptTaskParser, "ScriptTaskStateParser should not be null"); ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
