maple525866 commented on code in PR #7783:
URL: https://github.com/apache/incubator-seata/pull/7783#discussion_r2527311151


##########
core/src/main/java/org/apache/seata/core/rpc/netty/AbstractNettyRemotingClient.java:
##########
@@ -271,6 +287,11 @@ public void destroyChannel(String serverAddress, Channel 
channel) {
 
     @Override
     public void destroy() {
+        if (reconnectTimer != null && timerStarted.get()) {
+            reconnectTimer.shutdown();

Review Comment:
   Aside from the reconnection issue, logically speaking, there is also a race 
condition problem here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to