0x-infinity commented on code in PR #996:
URL: 
https://github.com/apache/incubator-seata-go/pull/996#discussion_r2553945209


##########
pkg/datasource/sql/async_worker.go:
##########
@@ -68,6 +69,10 @@ type AsyncWorker struct {
        doBranchCommitFailureTotal prometheus.Counter
        receiveChanLength          prometheus.Gauge
        rePutBackToQueue           prometheus.Counter
+
+       ctx    context.Context

Review Comment:
   You might consider whether there is a better approach, using context as a 
member of a struct is not a good practice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to