XiaoyangCai360 opened a new pull request, #7808:
URL: https://github.com/apache/incubator-seata/pull/7808
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR performs a fix and refactoring to eliminate flakiness in 10 unit
tests (the `testGetPkValues_SinglePk` and `testGetPkValues_MultiPk` methods)
across five database-specific Insert Executor test files: Kingbase, OceanBase,
Oracle, Oscar, and Postgresql.
The root cause was reliance on order-dependent assertions
(`Assertions.assertIterableEquals(Map.entrySet(), ...)`) against maps whose
iteration order is non-deterministic (`HashMap`).
The fix replaces the unreliable assertion with the correct
`Assertions.assertEquals(expectedMap, actualMap)` assertion, which compares the
key-value content of the maps directly, ensuring an order-independent and
stable test across all affected databases.
**No production code changes were made; these are test-only changes to
improve CI stability.**
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This PR specifically addresses the flakiness of existing unit tests
### Ⅳ. Describe how to verify it
To confirm the flakiness is resolved, run the affected tests repeatedly
using a non-deterministic test runner such as
[nondex](https://github.com/TestingResearchIllinois/NonDex) to verify
stability. Successful runs across multiple attempts verify the fix.
Verification can be done by targeting the following classes:
* `org.apache.seata.rm.datasource.exec.kingbase.KingbaseInsertExecutorTest`
* `org.apache.seata.rm.datasource.exec.oceanbase.OceanBaseInsertExecutorTest`
* `org.apache.seata.rm.datasource.exec.oracle.OracleInsertExecutorTest`
* `org.apache.seata.rm.datasource.exec.oracle.OscarInsertExecutorTest`
* `org.apache.seata.rm.datasource.exec.oracle.PostgresqlInsertExecutorTest`
For example, run the following command:
```bash
mvn -pl rm-datasource \
-am edu.illinois:nondex-maven-plugin:2.1.7:nondex \
-Dtest=org.apache.seata.rm.datasource.exec.KingbaseInsertExecutorTest \
-DnondexRuns=10 \
-DfailIfNoTests=false
```
### Ⅴ. Special notes for reviews
- Test-only change in the `rm-datasource` module.
- No production code modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
