slievrly commented on code in PR #7807:
URL: https://github.com/apache/incubator-seata/pull/7807#discussion_r2562560897
##########
rm-datasource/src/main/java/org/apache/seata/rm/datasource/util/XAUtils.java:
##########
@@ -64,8 +64,15 @@ public static XAConnection createXAConnection(Connection
physicalConn, Driver dr
} else {
return createXAConnection(physicalConn,
"oracle.jdbc.xa.client.OracleXAConnection", dbType);
}
- case JdbcConstants.MARIADB:
- return createXAConnection(physicalConn,
"org.mariadb.jdbc.MariaXaConnection", dbType);
+ case JdbcConstants.MARIADB: {
+ String xaConnectionClassName;
+ if (isMariaDb3x(driver)) {
+ xaConnectionClassName =
"org.mariadb.jdbc.MariaDbPooledConnection";
Review Comment:
It is suggested to define a constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
