cperkkk opened a new pull request, #7815:
URL: https://github.com/apache/incubator-seata/pull/7815
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Hi, I made a fix on this, since I've noticed that when running the test in
specific ordering for example when using newer maven surefire plugin / during
renaming:
```
mvn test
-Dtest=org.apache.seata.config.AbstractConfigurationTest#AtestGetConfigWithNull+BtestGetConfigWithDefaultValue
```
The tests will fail with output:
```
ERROR] Failures:
[ERROR] AbstractConfigurationTest.AtestGetConfigWithNull:152 expected: not
<null>
```
This is due to the necessity of the cache being set by
testGetConfigWithDefaultValue first, before the eventual testGetConfigWithNull
running, so there's an assumed ordering but the test fails to explicitly
guarantee the ordering (different version of maven surefire will run the order
randomly and if the test are refactored / renamed, the current test order will
change and it will fail), combining the test will help with removing this
flakiness.
### Ⅱ. Does this pull request fix one issue?
No
### Ⅲ. Why don't you add test cases (unit test/integration test)?
I've only changed test and not code under test
### Ⅳ. Describe how to verify it
We test the combined version
```
mvn test
-Dtest=org.apache.seata.config.AbstractConfigurationTest#testGetConfigWithDefaultValue
```
```
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
```
### Ⅴ. Special notes for reviews
- The fix ensures the test is robust to non-deterministic behaviors of
ordering, making it compatible with future updates to it or related
dependencies.
Let me know if further improvements or clarifications are needed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
