cperkkk commented on code in PR #7819:
URL: https://github.com/apache/incubator-seata/pull/7819#discussion_r2575157535
##########
common/src/test/java/org/apache/seata/common/rpc/RpcStatusTest.java:
##########
@@ -50,6 +50,10 @@ public void beginCount() {
@Test
public void endCount() {
+ // ensure a correct state before testing
Review Comment:
Hi @slievrly thank you for the reply:
this endCount and asserts to 0 only works if there's a beginCount before it
so it evaluates to +1-1==0, if I use beforeEach (for example adding
removeStatus), I also have to change assertions for the endCount to be -1,
instead of 0, do you prefer that to be used instead of the current one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
