rookiewwj commented on code in PR #1031: URL: https://github.com/apache/incubator-seata-go/pull/1031#discussion_r2622651153
########## pkg/remoting/getty/identity.go: ########## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package getty + +// ClientIdentity represents the identity of a seata client, +// including application ID and transaction service group. +type ClientIdentity struct { + ApplicationID string + TxServiceGroup string +} Review Comment: Do you mean dropping ClientIdentity and directly using ApplicationID and TxServiceGroup? I think keeping ClientIdentity is a bit cleaner, both in terms of code readability and overall code cleanliness, and it also keeps the parameters passed to InitGetty more concise. If we remove ClientIdentity, the main impact would be on the parameters of InitGetty; from an implementation perspective, it would be easy to change. Which approach do you think we should use? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
