mjs0514 commented on issue #7869:
URL: 
https://github.com/apache/incubator-seata/issues/7869#issuecomment-3660179108

   My suggestion is to have consistent table column names regardless of the 
database vendor.
   
   If the last resort you mentioned means using the column name "cluster" for 
other database vendors and using a different name, such as "cluster_name" only 
for Oracle, I don't think that's a good solution.
   
   For example, if the column name "cluster_name" isn't a reserved word in any 
database vendor, I think the vgroup_table table creation query should be as 
follows to avoid increased maintenance costs.
   
   ```
   // all db vendor
   CREATE TABLE vgroup_table
   (
       vGroup VARCHAR2(255) PRIMARY KEY,
       namespace VARCHAR2(255),
       cluster_name VARCHAR2(255)
   );
   ```
   
   In my testing, if the reserved word in the SQL statement wasn't enclosed in 
backticks or double quotes, the query failed when the string "cluster" was 
included in the where or select clause. 
   
   I think you'll know what I mean once you try it yourself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to