WangzJi commented on code in PR #7995:
URL: https://github.com/apache/incubator-seata/pull/7995#discussion_r2867184700
##########
seata-spring-boot-starter/src/test/java/org/apache/seata/spring/boot/autoconfigure/SeataAutoConfigurationTest.java:
##########
@@ -80,4 +84,99 @@ void testGlobalTransactionScannerBeanCreated() {
GlobalTransactionScanner scanner =
applicationContext.getBean(GlobalTransactionScanner.class);
assertThat(scanner).isNotNull();
}
+
+ @Test
+ void testGlobalTransactionScannerProperties() {
+ GlobalTransactionScanner scanner =
applicationContext.getBean(GlobalTransactionScanner.class);
+ assertThat(scanner).isNotNull();
+ // Verify scanner is configured with test properties
+ assertThat(scanner.getApplicationId()).isEqualTo("testApp");
+ assertThat(scanner.getTxServiceGroup()).isEqualTo("test_tx_group");
+ }
+
+ @Test
+ void testSeataPropertiesLoaded() {
+ // SeataProperties may be registered twice (@Component +
@EnableConfigurationProperties),
+ // so we use getBeansOfType to get any instance
+ java.util.Map<String, SeataProperties> beans =
applicationContext.getBeansOfType(SeataProperties.class);
Review Comment:
Please use imports instead of fully qualified names.
##########
seata-spring-boot-starter/src/test/java/org/apache/seata/spring/boot/autoconfigure/SeataAutoConfigurationTest.java:
##########
@@ -80,4 +84,99 @@ void testGlobalTransactionScannerBeanCreated() {
GlobalTransactionScanner scanner =
applicationContext.getBean(GlobalTransactionScanner.class);
assertThat(scanner).isNotNull();
}
+
+ @Test
+ void testGlobalTransactionScannerProperties() {
+ GlobalTransactionScanner scanner =
applicationContext.getBean(GlobalTransactionScanner.class);
+ assertThat(scanner).isNotNull();
+ // Verify scanner is configured with test properties
+ assertThat(scanner.getApplicationId()).isEqualTo("testApp");
+ assertThat(scanner.getTxServiceGroup()).isEqualTo("test_tx_group");
+ }
+
+ @Test
+ void testSeataPropertiesLoaded() {
+ // SeataProperties may be registered twice (@Component +
@EnableConfigurationProperties),
+ // so we use getBeansOfType to get any instance
+ java.util.Map<String, SeataProperties> beans =
applicationContext.getBeansOfType(SeataProperties.class);
+ assertThat(beans.isEmpty()).isFalse();
+ SeataProperties seataProperties = beans.values().iterator().next();
+ assertThat(seataProperties).isNotNull();
+ assertThat(seataProperties.isEnabled()).isTrue();
+ assertThat(seataProperties.getApplicationId()).isEqualTo("testApp");
+
assertThat(seataProperties.getTxServiceGroup()).isEqualTo("test_tx_group");
+ }
+
+ /**
+ * Use ApplicationContextRunner for lightweight testing of disabled
scenarios
+ * and various property configurations, avoiding nested @SpringBootTest
issues.
+ */
+ @Test
+ void whenSeataDisabled_thenNoBeansCreated() {
Review Comment:
New tests should follow the existing conventions.
##########
seata-spring-boot-starter/src/test/java/org/apache/seata/spring/boot/autoconfigure/SeataAutoConfigurationTest.java:
##########
@@ -27,13 +28,16 @@
import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.boot.autoconfigure.AutoConfigurations;
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
import
org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.boot.test.context.SpringBootTest;
+import org.springframework.boot.test.context.runner.ApplicationContextRunner;
import org.springframework.context.ApplicationContext;
import org.springframework.context.annotation.Configuration;
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
Review Comment:
Please unify to `import static org.assertj.core.api.Assertions.assertThat`
It's the recommended single entry point for AssertJ and covers all types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
