ban-xiu opened a new pull request, #8017:
URL: https://github.com/apache/incubator-seata/pull/8017
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
## Problem Background
In Docker deployment scenarios using port mapping (e.g., `-p 21908:8091`),
the Seata Server listens on port 8091 inside the container. However, clients
need to access it through the host's port 21908. Currently, both `SEATA_PORT`
and `seata.server.service-port` simultaneously control both the listening port
and the registration port, making separation impossible. Although `SEATA_IP`
already supports overriding the registered IP, there is no corresponding
mechanism for the port.
## Solution
Introduce a new optional configuration `seata.server.registry-port`
(environment variable `SEATA_REGISTRY_PORT`) that overrides only the port
registered to the service discovery center (Nacos, etc.), without affecting the
actual listening port of Netty. Behavior remains completely unchanged if not
configured.
## Main Changes
1. Extracted the original port resolution logic into `resolveServicePort()`
and added a new `resolveRegistryPort()`.
2. The resolution priority is: `SEATA_REGISTRY_PORT` environment variable >
`seata.server.registry-port` YAML configuration.
3. Port replacement occurs only at the two entry points in the registration
chain:
* `NettyServerBootstrap.start()`
* `VGroupMappingStoreManager.notifyMapping()`
4. The change takes effect uniformly for all registry centers (Nacos,
Eureka, etc.), eliminating the need for individual adaptations in each registry
implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
