thunguo commented on code in PR #1057:
URL:
https://github.com/apache/incubator-seata-go/pull/1057#discussion_r2915601773
##########
pkg/datasource/sql/xa/oracle_xa_connection.go:
##########
Review Comment:
Please refer to the comments for the issue mentioned. `go-ora` does not
directly support DBMS_XA PL/SQL, so you cannot directly apply the MySQL
implementation.
##########
pkg/datasource/sql/types/types.go:
##########
@@ -96,6 +96,10 @@ func ParseDBType(driverName string) DBType {
switch strings.ToLower(driverName) {
case "mysql":
return DBTypeMySQL
+ case "postgres", "postgresql", "pgx", "pq":
Review Comment:
Since PostgreSQL does not implement XA Connection, is it better to leave
this logic unprocessed for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
