funky-eyes commented on code in PR #8020:
URL: https://github.com/apache/incubator-seata/pull/8020#discussion_r2972484869
##########
core/src/main/java/org/apache/seata/core/protocol/Version.java:
##########
@@ -96,6 +102,22 @@ public static boolean isAboveOrEqualVersion230(String
version) {
return isAboveOrEqualVersion(version, VERSION_2_3_0);
}
+ public static boolean isAboveOrEqualVersion260(String version) {
+ return isAboveOrEqualVersion(version, VERSION_2_6_0);
+ }
+
+ public static void putServerVersion(String serverAddress, String version) {
+ SERVER_VERSION_MAP.put(serverAddress, version);
+ }
+
+ public static String getServerVersion(String serverAddress) {
+ return SERVER_VERSION_MAP.get(serverAddress);
+ }
+
+ public static void removeServerVersion(String serverAddress) {
Review Comment:
It seems that this method is not being called anywhere.
##########
core/src/main/java/org/apache/seata/core/protocol/Version.java:
##########
@@ -96,6 +102,22 @@ public static boolean isAboveOrEqualVersion230(String
version) {
return isAboveOrEqualVersion(version, VERSION_2_3_0);
}
+ public static boolean isAboveOrEqualVersion260(String version) {
Review Comment:
Storing the server version number cached by the client in the Version
class—could it be inappropriate?
##########
core/src/main/java/org/apache/seata/core/protocol/UnregisterRMRequest.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.seata.core.protocol;
+
+import java.io.Serializable;
+
+/**
+ * The type Unregister rm request.
+ */
+public class UnregisterRMRequest extends AbstractIdentifyRequest implements
Serializable {
+
+ public UnregisterRMRequest() {
+ this(null, null);
+ }
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
