Copilot commented on code in PR #8054: URL: https://github.com/apache/incubator-seata/pull/8054#discussion_r3208043995
########## changes/en-us/2.x.md: ########## @@ -62,6 +62,9 @@ Add changes here for all PR submitted to the 2.x branch. - [[#8031](https://github.com/apache/incubator-seata/pull/8031)] upgrade some dependencies versions - [[#8030](https://github.com/apache/incubator-seata/pull/8030)] add the dependency jackson-datatype-jsr310 - [[#8043](https://github.com/apache/incubator-seata/pull/8043)] simplify jackson related dependencies +- [[#8054](https://github.com/apache/incubator-seata/pull/8054)] console/namingserver/server modules：spring-boot upgrade to 4.0.5 Review Comment: The changelog entry says Spring Boot was upgraded to 4.0.5, but this PR updates module POMs to 4.0.6 (e.g., server/console/namingserver). Please update this entry to match the actual version upgraded in this PR. ########## changes/zh-cn/2.x.md: ########## @@ -63,6 +63,9 @@ - [[#8031](https://github.com/apache/incubator-seata/pull/8031)] 升级一些依赖版本 - [[#8030](https://github.com/apache/incubator-seata/pull/8030)] 添加依赖 jackson-datatype-jsr310 - [[#8043](https://github.com/apache/incubator-seata/pull/8043)] 简化 jackson 相关依赖 +- [[#8054](https://github.com/apache/incubator-seata/pull/8054)] console/namingserver/server 模块：spring-boot 升级到 4.0.5 Review Comment: The changelog entry says Spring Boot was upgraded to 4.0.5, but this PR updates module POMs to 4.0.6 (e.g., server/console/namingserver). Please update this entry to match the actual version upgraded in this PR. ########## server/src/main/java/org/apache/seata/server/cluster/raft/context/SeataClusterContext.java: ########## @@ -16,14 +16,13 @@ */ package org.apache.seata.server.cluster.raft.context; +import jakarta.annotation.Nonnull; +import jakarta.annotation.Nullable; Review Comment: `jakarta.annotation.Nonnull`/`jakarta.annotation.Nullable` are introduced here, but the rest of the codebase predominantly uses `javax.annotation.Nonnull`/`javax.annotation.Nullable` for these nullness annotations. To avoid inconsistent nullness annotation types (and potential missing-class issues depending on the chosen annotation API), consider keeping `javax.annotation.*` for Nonnull/Nullable (or switching consistently to a single nullness annotation set such as JSpecify) instead of mixing packages. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
