Copilot commented on code in PR #8103: URL: https://github.com/apache/incubator-seata/pull/8103#discussion_r3254833966
########## extensions/rpc/seata-sofa-rpc/src/main/java/org/apache/seata/integration/sofa/rpc/TransactionContextConsumerFilter.java: ########## @@ -16,108 +16,35 @@ */ package org.apache.seata.integration.sofa.rpc; -import com.alipay.sofa.rpc.context.RpcInternalContext; import com.alipay.sofa.rpc.core.exception.SofaRpcException; import com.alipay.sofa.rpc.core.request.SofaRequest; import com.alipay.sofa.rpc.core.response.SofaResponse; import com.alipay.sofa.rpc.ext.Extension; import com.alipay.sofa.rpc.filter.AutoActive; import com.alipay.sofa.rpc.filter.Filter; import com.alipay.sofa.rpc.filter.FilterInvoker; -import org.apache.seata.common.util.StringUtils; -import org.apache.seata.core.context.RootContext; -import org.apache.seata.core.model.BranchType; -import org.slf4j.Logger; -import org.slf4j.LoggerFactory; +import org.apache.seata.integration.rpc.core.TransactionPropagationHandler; Review Comment: This import references `org.apache.seata.integration.rpc.core.TransactionPropagationHandler`, but `seata-rpc-core` does not define that class after this refactor (the existing core filter interfaces were removed and no replacement source file is present). As a result, every module importing this type fails to compile; add the shared handler implementation to `seata-rpc-core` or update these imports to an existing API. ########## extensions/rpc/seata-motan/src/main/resources/META-INF/services/com.weibo.api.motan.filter.Filter: ########## @@ -14,4 +14,5 @@ # See the License for the specific language governing permissions and # limitations under the License. # -org.apache.seata.integration.motan.MotanTransactionFilter \ No newline at end of file +org.apache.seata.integration.motan.MotanTransactionConsumerFilter +org.apache.seata.integration.motan.MotanTransactionProviderFilter Review Comment: The service descriptor now advertises `MotanTransactionConsumerFilter` and `MotanTransactionProviderFilter`, but the `seata-motan` module contains no Java classes with those names after `MotanTransactionFilter` was deleted. Motan SPI loading will fail to instantiate these filters; add the two replacement classes or keep the descriptor pointing at an existing implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
