funky-eyes commented on code in PR #8106:
URL: https://github.com/apache/incubator-seata/pull/8106#discussion_r3295925545
##########
spring/src/main/java/org/apache/seata/spring/annotation/GlobalTransactionScanner.java:
##########
@@ -518,7 +518,7 @@ private MethodDesc makeMethodDesc(GlobalTransactional anno,
Method method) {
@Override
protected Object[] getAdvicesAndAdvisorsForBean(Class beanClass, String
beanName, TargetSource customTargetSource)
throws BeansException {
- return new Object[] {interceptor};
+ return interceptor == null ? DO_NOT_PROXY : new Object[] {interceptor};
Review Comment:
Is this fix addressing the same issue as the one described in the issue? If
the interceptor is not initialized, does that essentially mean it is being
bypassed? If it is bypassed, wouldn’t that mean the global transaction is not
taking effect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
