Zhengcy05 opened a new pull request, #8140:
URL: https://github.com/apache/incubator-seata/pull/8140
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [x] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR adds a tracked wrapper for `BusinessActionContext.actionContext` so
that Map-level mutations in the Try phase, such as `put`, `putAll`, `remove`,
`clear`, `replace`, `compute*`, and `merge`, automatically mark `updated` as
`true`. This reduces the need for business code to call `setUpdated(true)`
manually.
It also adjusts the initialization timing in `ActionInterceptorHandler` to
ensure framework-side setup does not incorrectly trigger `updated`, while
business-side changes are still captured and reported correctly in phase two.
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes
#97. -->
fixes #7954
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Test cases have been added to cover the new behavior.
### Ⅳ. Describe how to verify it
Run:
```bash
mvn -P '!java17+' -Dremoteresources.skip=true -Djacoco.skip=true
-Dmaven.simplify.skip=true -DfailIfNoTests=false
-Dmaven.repo.local=/private/tmp/codex-m2 -f pom.xml -pl integration-tx-api -am
-Dtest=ActionInterceptorHandlerTest,BusinessActionContextTest test
```
Verification:
- BusinessActionContextTest covers actionContext mutations and automatic
updated marking.
- ActionInterceptorHandlerTest covers business-side changes being reported
correctly in the Try phase.
### Ⅴ. Special notes for reviews
This change only covers Map-level tracking for actionContext. It does not
add deep proxying or dirty tracking for nested object fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
