Seol-JY commented on code in PR #8138:
URL: https://github.com/apache/incubator-seata/pull/8138#discussion_r3385000087
##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/fence/store/db/CommonFenceStoreDataBaseDAO.java:
##########
@@ -189,6 +189,8 @@ public int deleteTCCFenceDO(Connection conn, List<String>
xids) {
for (int i = 0; i < xids.size(); i++) {
Review Comment:
The only caller, SpringFenceHandler#deleteFenceByDate, already breaks out on
an empty xid set before calling this, so IN () / null datetime aren't
reachable. This is unchanged from the previous behavior, so I'll leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
