yunfan24 commented on PR #1120: URL: https://github.com/apache/incubator-seata-go/pull/1120#issuecomment-4701265951
Among the 29 merged PRs in arana-db/parser, a large portion are Arana-specific features, such as sharding rule inspection, topology management, multi-tenant syntax, and DRDS partitioning. seata-go has zero references to these features, and they are unrelated to distributed transactions. Some features are already supported by newer versions of TiDB, such as SHOW REPLICA STATUS, ADMIN CHECK TABLE, and SHOW EXTENDED COLUMNS/FIELDS. What seata-go actually depends on is entirely standard parser API functionality: SQL parsing, AST traversal, SQL restoration, and parameter markers. It does not depend on any Arana-specific custom functionality. The only risk point is that arana-db/parser fills ParamMarkerExpr.Order during parsing, while the official TiDB parser does not. Although TiDB defines the SetOrder interface, parser.y never calls it. seata-go depends on this field for parameter binding, and the migration has already adapted the seata-go code to handle this. So it seems reasonable to switch directly to the latest TiDB parser, without maintaining a local fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
