Zhengcy05 opened a new pull request, #8157:
URL: https://github.com/apache/incubator-seata/pull/8157
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
This PR fixes a Spring Boot 4.x compatibility issue in
`SeataSagaAutoConfiguration`.
`SeataSagaAutoConfiguration` previously used a hard class reference to
`org.springframework.boot.autoconfigure.jdbc.DataSourceAutoConfiguration` in
`@AutoConfigureAfter`. On Spring Boot 4.x, `DataSourceAutoConfiguration` was
moved to `org.springframework.boot.jdbc.autoconfigure`, so the old class
reference could trigger `TypeNotPresentException` during meta-annotation
introspection and cause the whole Saga auto-configuration to be skipped.
This PR updates the auto-configuration ordering to use string-based class
names for both Spring Boot 2.x/3.x and Spring Boot 4.x, following the same
compatibility pattern already used in other Seata auto-configuration classes.
It also adds a regression test to verify the annotation metadata.
### Ⅱ. Does this pull request fix one issue?
fixes #8153
### Ⅲ. Why don't you add test cases (unit test/integration test)?
A regression test was added in `SeataSagaAutoConfigurationTest` to verify
that `@AutoConfigureAfter` keeps `SeataAutoConfiguration.class` in `value()`
and uses both Spring Boot 2.x/3.x and 4.x `DataSourceAutoConfiguration` class
names in `name()`.
### Ⅳ. Describe how to verify it
Run:
`mvn -pl spring/seata-spring-boot-starter -am
-Dtest=SeataSagaAutoConfigurationTest -DfailIfNoTests=false
-Dmaven.repo.local=/private/tmp/incubator-seata-m2 test`
### Ⅴ. Special notes for reviews
I have not registered the `changes` entry yet. If this direction looks good,
I can add the corresponding `changes/en-us/2.x.md` and `changes/zh-cn/2.x.md`
entries before merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
