AsperforMias commented on code in PR #1136:
URL:
https://github.com/apache/incubator-seata-go/pull/1136#discussion_r3542858641
##########
pkg/datasource/sql/exec/at/insert_executor.go:
##########
@@ -707,7 +723,7 @@ func (i *insertExecutor) getPkValuesByAuto(ctx
context.Context, execCtx *types.E
// If there is batch insert
// do auto increment base LAST_INSERT_ID and variable
`auto_increment_increment`
- if lastInsertId > 0 && updateCount > 1 && canAutoIncrement(pkMetaMap) {
+ if lastInsertId > 0 && updateCount > 1 {
Review Comment:
这个本来是因为旧的 `canAutoIncrement` 它只允许单一的主键,会卡复合主键里的「自增列的场景」,现在new commit这边改成
`canAutoGeneratePKs` ,只去判断主键里「有没有自增列」,这样就不限制主键数量了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]