pyshiweijia commented on PR #8167: URL: https://github.com/apache/incubator-seata/pull/8167#issuecomment-5001997799
I checked the current head (`a329bcaf`) locally with: `mvn -pl common -am test -Dtest=NetUtilTest -Dsurefire.failIfNoSpecifiedTests=false -Dlicense.skip=true -B` All 31 `NetUtilTest` cases pass. I found two follow-ups before merge: 1. Both `changes/en-us/2.x.md` and `changes/zh-cn/2.x.md` link to `#8159`, but this PR is `#8167`. 2. The new test covers `convertIpIfNecessary`, whose resolution behavior already existed; it would still pass if `Server` accidentally kept passing `rawHost` to `XID.setIpAddress`. Could you add focused coverage that configures a hostname and asserts that the value assigned to `XID` is the resolved IP literal? Extracting the host-selection/assignment logic into a package-private method may make that path easy to test. That second test would directly guard the regression reported in #8158. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
