coyaSONG opened a new pull request, #8172: URL: https://github.com/apache/incubator-seata/pull/8172
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines. - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes). ### Ⅰ. Describe what this PR did Wait for the asynchronous `CachedConfigurationChangeListener` callback in `ConfigurationChangeListenerTest` before asserting that it ran. This replaces the immediate assertion and removes the broad exception handler that could hide executor failures. ### Ⅱ. Does this pull request fix one issue? Fixes #8171. ### Ⅲ. Why don't you add test cases (unit test/integration test)? This change corrects the existing regression test itself; it does not change production behavior. ### Ⅳ. Describe how to verify it On protected `2.x` at `e6d0860a4345b10cb59c65c78215ec51d67f59d1`, the targeted test class failed at `testCachedConfigurationChangeListener` because the assertion ran before the executor callback. After this change, the same command passes all 10 tests: ```shell ./mvnw -pl config/seata-config-core -am -Dtest=ConfigurationChangeListenerTest -DfailIfNoTests=false test ``` `git diff --check` also passes. ### Ⅴ. Special notes for reviews The wait is bounded to five seconds and is released directly by the callback under test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
