funky-eyes commented on code in PR #8163:
URL: https://github.com/apache/incubator-seata/pull/8163#discussion_r3618781142
##########
json-common/json-common-core/src/main/java/org/apache/seata/common/json/JsonUtil.java:
##########
@@ -42,19 +43,32 @@ public final class JsonUtil {
JsonSerializerFactory.getSerializer(CONFIG_JSON_SERIALIZER_NAME);
static String resolveJsonSerializerName(Configuration configuration) {
- String serializerType =
configuration.getConfig(ConfigurationKeys.JSON_SERIALIZER_TYPE);
- if (StringUtils.isNotBlank(serializerType)) {
- return serializerType;
- }
-
- String deprecatedSerializerType =
+ String deprecatedTccSerializerType =
Review Comment:
> JsonUtil first reads the deprecated TCC/Saga configuration, and then reads
the json.serializerType; however, the published client file.conf still sets
client.rm.sagaJsonParser = "fastjson" by default. Therefore, even if the user
configures json.serializerType=fastjson2, fastjson is still used in practice
I suggest that in version 2.8, we prioritize reading json.serializerType. If
it is not set, we should fall back to the JSON configuration under Saga.
The TCC configuration can be removed entirely in 2.8, since it was already
deprecated in 2.7 and no longer needs to be kept for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
