xuxiaowei-com-cn commented on PR #8165:
URL: https://github.com/apache/incubator-seata/pull/8165#issuecomment-5095426132
@slievrly
1. Scope creep:
1. `release-seata-jar` is used to package into a .jar file, then the
following command is used to collect GraalVM native data. Reference:
https://github.com/xuxiaowei-com-cn/incubator-seata/blob/xuxiaowei/schedule-native/README.md
```shell
${GRAALVM_HOME}/bin/java
-agentlib:native-image-agent=config-output-dir=./target/native-image-config
-jar ./namingserver/target/seata-namingserver.jar
```
2. Comments have been added to the SingleResult.java no-arg constructor.
2. logback-spring.xml:
1. When using logback-spring-native.xml, it is difficult to specify
after the GraalVM native build is completed.
2. A changelog entry for the logback-spring.xml changes has been added.
3. Python as a build dependency:
1. Has been replaced with a pure Java implementation (no external
dependencies).
4. Baseline metadata — reviewability and stability:
1.
https://github.com/xuxiaowei-com-cn/incubator-seata/blob/xuxiaowei/schedule-native/README.md
describes the daily scheduled data collection approach.
2. Some dependencies do not natively support GraalVM native by default,
so they need to be added in this project. Entries like
`ch.qos.logback.classic.*` and `apple.security.AppleProvider` are non-seata and
are correct.
5. Test coverage & CI shape:
1. test-native-namingserver is an e2e test, not activated by default. It
is used only when CI or standalone testing of GraalVM native build artifacts is
performed.
2. Comments have been added to the test-native-namingserver test class.
3. macos-26: Public project CI should be free of charge. macos-latest
currently points to macos-26. This is a pinned version here; see:
https://github.com/actions/runner-images
4. In CI, running the server is only required for executing
test-native-namingserver e2e tests against the GraalVM native namingserver API
after the namingserver build is completed.
6. Minor:
1. For released versions of native-maven-plugin, see:
https://repo1.maven.org/maven2/org/graalvm/buildtools/native-maven-plugin/maven-metadata.xml
2. native-maven-plugin 1.1.5 is currently the highest released version.
3. The empty buildArgs block has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
