somiljain2006 commented on PR #8127: URL: https://github.com/apache/incubator-seata/pull/8127#issuecomment-5100855115
@slievrly Thanks for the detailed review I've updated the implementation so that expression re-evaluation is no longer the primary mechanism. During forward execution, the current loop element is captured by LoopTaskHandlerInterceptor and persisted into StateInstance.extensionParams via ServiceTaskHandlerInterceptor before recordStateStarted(). The extensionParams are serialized into the ext_params column and restored when the state instance is reloaded. During compensation, the loop element is restored directly from the persisted extensionParams. Expression re-evaluation is now only retained as a compatibility fallback for state instances that do not contain persisted loop metadata. I also added bounds checking to iterator() and WARN logging when fallback reconstruction is required or cannot be performed. Regarding the tests, I added a database-backed integration test covering persistence and restoration of the loop element through StateLogStore, in addition to the unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
