funky-eyes commented on code in PR #8188:
URL: https://github.com/apache/incubator-seata/pull/8188#discussion_r3719774476
##########
integration-tx-api/src/main/java/org/apache/seata/integration/tx/api/interceptor/ActionInterceptorHandler.java:
##########
@@ -53,6 +57,21 @@ public class ActionInterceptorHandler {
private static final Logger LOGGER =
LoggerFactory.getLogger(ActionInterceptorHandler.class);
+ /**
+ * Whether action status report is enabled. Restricted to {@link
BranchType#SAGA_ANNOTATION} so that enabling
+ * this option does not affect normal TCC behavior. Overridable for
testing.
+ *
+ * @param branchType the branch type of the current action
+ * @return true if action status should be reported
+ */
+ protected boolean isActionStatusReportEnabled(BranchType branchType) {
+ return branchType == BranchType.SAGA_ANNOTATION
Review Comment:
Why do we call ConfigurationFactory.getInstance().getBoolean() every time to
retrieve this value? I think we should define a variable and initialize it once
at application startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
