Anon2Tokyo opened a new pull request, #8199:
URL: https://github.com/apache/incubator-seata/pull/8199
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing
guidelines -->
- [x] I have read the
[CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md)
guidelines.
- [ ] I have registered the PR
[changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Optimize the RM/TM client reconnect scheduling in
`AbstractNettyRemotingClient`.
The reconnect timer is now backed by a shared scheduled executor, and
reconnect tasks are registered by transaction role. This avoids repeatedly
scheduling reconnect tasks when clients with the same role are initialized.
A behavior test was added to verify that reconnect tasks are shared by
transaction role and are only cancelled by the owner client.
### Ⅱ. Does this pull request fix one issue?
fixes #5338
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Added unit coverage in `NettyRemotingClientBehaviorTest`.
### Ⅳ. Describe how to verify it
```shell
mvn -pl core -am -Dtest=NettyRemotingClientBehaviorTest
-DfailIfNoTests=false test
```
### Ⅴ. Special notes for reviews
This change only shares the reconnect scheduler. The existing
`timerExecutor` remains unchanged because it is also used by other timeout and
cleanup tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
