Vanillaxi commented on code in PR #1141:
URL:
https://github.com/apache/incubator-seata-go/pull/1141#discussion_r3868219392
##########
pkg/datasource/sql/undo/executor/mysql_undo_insert_executor.go:
##########
@@ -43,13 +43,19 @@ func newMySQLUndoInsertExecutor(sqlUndoLog undo.SQLUndoLog)
*mySQLUndoInsertExec
// ExecuteOn execute insert undo logic
func (m *mySQLUndoInsertExecutor) ExecuteOn(ctx context.Context, dbType
types.DBType, conn *sql.Conn) error {
m.BaseExecutor.dbType = dbType
-
- if err := m.BaseExecutor.ExecuteOn(ctx, dbType, conn); err != nil {
+ ok, err := m.BaseExecutor.dataValidationAndGoOn(ctx, conn)
Review Comment:
Thanks. `DECIMAL`/`NUMERIC` values are now scanned as `sql.NullString` when
building new undo images. Legacy undo logs containing `float32`/`float64`
decimal values continue to use `sql.NullFloat64` for backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
