XiaoFeiASK commented on PR #1166: URL: https://github.com/apache/incubator-seata-go/pull/1166#issuecomment-5540874646
Thanks for the detailed review. I have addressed the comments as follows: 1. I will address the similar RM remoting issues in a separate issue and follow-up PR. They are not included in this PR. 2. Updated the PR description and release note to clarify that this is a gRPC wire-format consistency fix with the Java client. It does not change user-facing transaction behavior or affect TC request routing in the current implementation. 3. Updated the regression test to track whether `Commit()` actually calls `SendSyncRequest`, and added an assertion to prevent the test from passing vacuously. 4. Added a bugfix entry for issue #1165 to `changes/dev.md`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
