terrymanu edited a comment on issue #1775: Leaf key generator implementation for Apache ShardingSphere URL: https://github.com/apache/incubator-shardingsphere/issues/1775#issuecomment-492958293 @wgy8283335 Thank you for pay attention on this issue. > 1. As you know the leaf generator needs zookeeper client to communicate with zookeeper server. So the way of initializing the zookeeper client is a little hard to decide. Although, initializing the client and the definition of the client has been implemented in 'package org.apache.shardingsphere.orchestration.reg'. But it is hard to use them directly,.Beacuse the key generator is in 'package org.apache.shardingsphere.core.strategy.keygen'. So I'm planning to write these part on my own to initialize the client and the related functions. I prefer the agree your point, because reg module is for orchestration only, not for sharding-core, so just copy some core codes to leaf plugin is fine. > 2. The property of the leaf segment generator, especially zookeeper client related.I'd like to use new parameter，this means orchestration register related parameter won't be used. Yes, it should use new parameters, and we can put them to properties to let leaf plugin to read them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
