sunbufu commented on issue #2666: Fixes #2629 URL: https://github.com/apache/incubator-shardingsphere/pull/2666#issuecomment-509087320 You are right, ShardingRule is meaningless with a null ShardingRuleConfig. So, we need a judge in ShardingRule's constructor. and I notice there may throw a NPE in `ShardingRule.createEncryptRule()` when `shardingRuleConfig` is null. There is a question. Should I throw a `ShardingException` or `IllegalArgumentException` on this case? If we choose `ShardingException`, I need modify `dataSourceNames`'s judge too.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
