penghuiy edited a comment on issue #2663: how to set datasource readonly URL: https://github.com/apache/incubator-shardingsphere/issues/2663#issuecomment-508820982 @terrymanu I have found a discussion about the hikari pool(https://github.com/brettwooldridge/HikariCP/issues/1116). Based on the results of the discussion, I think I should explicitly specify isReadOnly. If not specified, the jdbc driver will throw an exception unpredictably, resulting in a connection not being established properly. I think the YamlDataSourceParameter should add the isReadOnly parameter and set a default value, then config.setReadOnly(dataSourceParameter.isReadOnly()); Please let me know if there are other objections.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
