tuohai666 commented on a change in pull request #2668: add
`getValueByColumnType` method
URL:
https://github.com/apache/incubator-shardingsphere/pull/2668#discussion_r300999059
##########
File path:
sharding-core/sharding-core-execute/src/main/java/org/apache/shardingsphere/core/execute/sql/execute/result/StreamQueryResult.java
##########
@@ -68,12 +68,12 @@ public boolean next() throws SQLException {
@Override
public Object getValue(final int columnIndex, final Class<?> type) throws
SQLException {
- return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex));
+ return decrypt(columnIndex, QueryResultUtil.getValue(resultSet,
columnIndex, type));
Review comment:
It's OK. We have noticed your work and expect more contribution from you. I
suggest you become a contributor first, then try to become a committer.
> And I have a question. Why do we need to create a QueryRow Iterator in
MemoryQueryResult and manage it ? Why not do just like [druid's
DruidPooledResultSet](https://github.com/alibaba/druid/blob/master/src/main/java/com/alibaba/druid/pool/DruidPooledResultSet.java)
？
Sometimes we need to get all data to memory:
1. Merge engine:
https://shardingsphere.apache.org/document/current/en/features/sharding/principle/merge/
2. Execute engine:
https://shardingsphere.apache.org/document/current/en/features/sharding/principle/execute/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
