kezhenxu94 commented on a change in pull request #2678: Fix#2629
URL:
https://github.com/apache/incubator-shardingsphere/pull/2678#discussion_r301135293
##########
File path:
sharding-core/sharding-core-common/src/test/java/org/apache/shardingsphere/core/rule/ShardingDataSourceNamesTest.java
##########
@@ -90,4 +91,15 @@ public void
assertGetDefaultDataSourceNameWithoutMasterSlaveDataSourceName() {
String actual = new ShardingDataSourceNames(shardingRuleConfig,
Arrays.asList("master_ds",
"slave_ds")).getRawMasterDataSourceName("default_ds");
assertThat(actual, is("default_ds"));
}
+
+ @Test
Review comment:
```suggestion
@Test(expected = IllegalArgumentException.class)
```
will free you from catching exceptions manually and determining their types
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
