wgy8283335 opened a new issue #2693: The method "ShardingInsertOptimizedStatement.addUnit()" has done more than one thing URL: https://github.com/apache/incubator-shardingsphere/issues/2693 ## The method "ShardingInsertOptimizedStatement.addUnit()" has done more than one thing The method "ShardingInsertOptimizedStatement.addUnit()" has done more than one thing:create InsertOptimizeResult Object and add it to the member 'units'. I think it is better to split the method into two parts. One method creates InsertOptimizeResult and Another use this InsertOptimizeResult Object as input to add it in the member 'units'.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
