betterjava commented on issue #2478: Use SPI to handle initialization of different Opentracing implements URL: https://github.com/apache/incubator-shardingsphere/issues/2478#issuecomment-521565698 @tuohai666 I tested it for SkyWalking with sharding-jdbc and sharding-proxy. But the Zipkin client Brave does not have default implements for Opentracing. I have try my hard to convert brave to Opentracing, but still have some methods can not convert success.I have change nothing in using Opentracing,just provide a SPI for getting a Opentracing Tracer. Do you have any suggestions for me?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services