terrymanu commented on issue #2949: 4.0.0-RC2 does not support Oracle 12C connection configuration #2911 URL: https://github.com/apache/incubator-shardingsphere/pull/2949#issuecomment-526879853 @timchan1011 Thank you for contribute code, I just add some code review, can you consider about how to refactor them? code conduct FYI: https://shardingsphere.apache.org/community/en/contribute/code-conduct/
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
