beckhampu commented on a change in pull request #3039: sharding-ui-frontend add
unit test
URL:
https://github.com/apache/incubator-shardingsphere/pull/3039#discussion_r324625892
##########
File path: sharding-ui/sharding-ui-frontend/src/components/Logo/index.vue
##########
@@ -18,8 +18,8 @@
<template>
<div class="s-pro-components-sider-menu-index-logo">
<a href="/">
- <img class src="../../assets/img/sidebar-logo.png" alt="logo">
- <img class="collapse-logo" src="../../assets/img/logo.png" alt="logo">
+ <img src="../../assets/img/sidebar-logo.png" alt="logo" />
Review comment:
```suggestion
<img src="../../assets/img/sidebar-logo.png" alt="logo" >
```
Here is eslint error: Disallow self-closing on HTML void elements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
