SanmuWangZJU commented on issue #3127: CPU LOAD  more than 300%
URL: 
https://github.com/apache/incubator-shardingsphere/issues/3127#issuecomment-535825085
 
 
   Hi @tuohai666 , I find that 
org.apache.shardingsphere.core.parse.cache.SQLParseResultCache#cache is using 
new ReferenceMap<>(), which seems to be not thread safe (and not thread local).
   
   Could you please explain the reason for not using a thread safe cache ? Or 
do you have other strategy guarantee visiting this cache safely? Perhaps it's 
better to use a cache like com.google.common.cache.Cache or at least a thread 
safe map.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to