terrymanu commented on issue #3147: LogicSchema#getDataSources unit test URL: https://github.com/apache/incubator-shardingsphere/pull/3147#issuecomment-536379622 @kezhenxu94 The getter method should not add unit test. But for this method, it is not only a getter method, it has some business logic which is use `backendDataSource.getDataSourceParameters()`, so for my understanding, add test case and mock backendDataSource is fine. We can merge it after fix change requested, because it will increase test coverage and not break any thing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
