terrymanu commented on issue #3147: LogicSchema#getDataSources unit test URL: https://github.com/apache/incubator-shardingsphere/pull/3147#issuecomment-536381778 Sorry, I see it carefully, it have a problem. This case is tesing `LogicSchema` which you are mocked, it is not a good practice. You may add a test fixture extends `LogicSchema`, and make the test fixture as `actual` object which you need to test.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
