terrymanu commented on a change in pull request #3158: test added for package
of org.apache.shardingsphere.core.optimize.segment.insert
URL:
https://github.com/apache/incubator-shardingsphere/pull/3158#discussion_r329442062
##########
File path:
sharding-core/sharding-core-preprocessor/src/main/java/org/apache/shardingsphere/core/optimize/segment/insert/InsertValueContext.java
##########
@@ -47,13 +47,13 @@
private final List<Object> parameters;
- public InsertValueContext(final Collection<ExpressionSegment> assignments,
final List<Object> parameters, final int parametersOffset) {
+ public InsertValueContext(final Collection<? extends ExpressionSegment>
assignments, final List<? extends Object> parameters, final int
parametersOffset) {
Review comment:
should not use List<? extends Object>, just keep original signature to keep
consist with user parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
