terrymanu commented on a change in pull request #3158: testcase code added for
package of org.apache.shardingsphere.core.optimize.segment.insert
URL:
https://github.com/apache/incubator-shardingsphere/pull/3158#discussion_r329564613
##########
File path:
sharding-core/sharding-core-preprocessor/src/main/java/org/apache/shardingsphere/core/optimize/segment/insert/InsertValueContext.java
##########
@@ -53,7 +53,7 @@ public InsertValueContext(final
Collection<ExpressionSegment> assignments, final
this.parameters = getParameters(parameters, parametersOffset);
}
- private int calculateParametersCount(final Collection<ExpressionSegment>
assignments) {
+ private int calculateParametersCount(final Collection<? extends
ExpressionSegment> assignments) {
Review comment:
Please do not change main codes if the proposal of this pr is add test cases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
