terrymanu commented on a change in pull request #3158: testcase code added for package of org.apache.shardingsphere.core.optimize.segment.insert URL: https://github.com/apache/incubator-shardingsphere/pull/3158#discussion_r330392053
########## File path: sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/optimize/segment/insert/InsertValueContextTest.java ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.core.optimize.segment.insert; + +import com.google.common.collect.Lists; +import org.apache.shardingsphere.core.optimize.segment.insert.expression.DerivedLiteralExpressionSegment; +import org.apache.shardingsphere.core.optimize.segment.insert.expression.DerivedParameterMarkerExpressionSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.expr.ExpressionSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.expr.simple.LiteralExpressionSegment; +import org.apache.shardingsphere.core.parse.sql.segment.dml.expr.simple.ParameterMarkerExpressionSegment; +import org.junit.Test; + +import java.lang.reflect.InvocationTargetException; +import java.lang.reflect.Method; +import java.util.Collection; +import java.util.Collections; +import java.util.List; + +import static org.hamcrest.MatcherAssert.assertThat; +import static org.hamcrest.core.Is.is; + +public final class InsertValueContextTest { + + @Test + public void assertInstanceConstructedOk() throws NoSuchMethodException, InvocationTargetException, IllegalAccessException { + Collection<ExpressionSegment> assignments = Lists.newArrayList(); + List<Object> parameters = Collections.emptyList(); + int parametersOffset = 0; + InsertValueContext insertValueContext = new InsertValueContext(assignments,parameters, parametersOffset); + Method calculateParametersCountMethod = InsertValueContext.class.getDeclaredMethod("calculateParametersCount", Collection.class); + calculateParametersCountMethod.setAccessible(true); + int calculateParametersCountResult = (int) calculateParametersCountMethod.invoke(insertValueContext, new Object[] {assignments}); + assertThat(insertValueContext.getParametersCount(), is(calculateParametersCountResult)); + Method getValueExpressionsMethod = InsertValueContext.class.getDeclaredMethod("getValueExpressions", Collection.class); + getValueExpressionsMethod.setAccessible(true); + List<ExpressionSegment> getValueExpressionsResult = (List<ExpressionSegment>) getValueExpressionsMethod.invoke(insertValueContext, new Object[] {assignments}); + assertThat(insertValueContext.getValueExpressions(), is(getValueExpressionsResult)); + Method getParametersMethod = InsertValueContext.class.getDeclaredMethod("getParameters", new Class[]{List.class, int.class}); + getParametersMethod.setAccessible(true); + List<Object> getParametersResult = (List<Object>) getParametersMethod.invoke(insertValueContext, new Object[] {parameters, parametersOffset}); + assertThat(insertValueContext.getParameters(), is(getParametersResult)); + } + + @Test + public void assertGetValueWhenParameterMarker() { + Collection<ExpressionSegment> assignments = makeParameterMarkerExpressionSegment(); + String parameterValue = "test"; + List<Object> parameters = Collections.<Object>singletonList(parameterValue); + int parametersOffset = 0; + InsertValueContext insertValueContext = new InsertValueContext(assignments,parameters, parametersOffset); + Object result = insertValueContext.getValue(0); + assertThat((String)result, is(parameterValue)); + } + + private Collection<ExpressionSegment> makeParameterMarkerExpressionSegment() { + ParameterMarkerExpressionSegment parameterMarkerExpressionSegment = new ParameterMarkerExpressionSegment(0, 10, 5); + return Collections.<ExpressionSegment>singleton(parameterMarkerExpressionSegment); + } + + @Test + public void assertGetValueWhenLiteralExpressionSegment() { + Object literalObject = new Object(); + Collection<ExpressionSegment> assignments = makeLiteralExpressionSegment(literalObject); + List<Object> parameters = Collections.emptyList(); + InsertValueContext insertValueContext = new InsertValueContext(assignments,parameters, 0); + Object result = insertValueContext.getValue(0); + assertThat(result, is(literalObject)); + } + + private Collection<ExpressionSegment> makeLiteralExpressionSegment(final Object literalObject) { + LiteralExpressionSegment parameterMarkerExpressionSegment = new LiteralExpressionSegment(0, 10, literalObject); + return Collections.<ExpressionSegment>singleton(parameterMarkerExpressionSegment); + } + + @Test + public void assertAppendValueWhenParametersIsEmpty() { + Collection<ExpressionSegment> assignments = Collections.emptyList(); + List<Object> parameters = Collections.emptyList(); + InsertValueContext insertValueContext = new InsertValueContext(assignments,parameters, 0); + Object value = "test"; + String type = "String"; + insertValueContext.appendValue(value, type); + List<ExpressionSegment> valueExpressions = insertValueContext.getValueExpressions(); + assertThat(valueExpressions.size(), is(1)); + DerivedLiteralExpressionSegment segmentInInsertValueContext = (DerivedLiteralExpressionSegment) valueExpressions.get(0); + assertThat(segmentInInsertValueContext.getType(), is(type)); + assertThat(segmentInInsertValueContext.getLiterals(), is(value)); + } + Review comment: indents should be 4 space here ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
