terrymanu commented on a change in pull request #3158: testcase code added for
package of org.apache.shardingsphere.core.optimize.segment.insert
URL:
https://github.com/apache/incubator-shardingsphere/pull/3158#discussion_r330391658
##########
File path:
sharding-core/sharding-core-preprocessor/src/main/java/org/apache/shardingsphere/core/optimize/segment/insert/InsertValueContext.java
##########
@@ -88,7 +88,7 @@ public Object getValue(final int index) {
ExpressionSegment valueExpression = valueExpressions.get(index);
return valueExpression instanceof ParameterMarkerExpressionSegment ?
parameters.get(getParameterIndex(valueExpression)) :
((LiteralExpressionSegment) valueExpression).getLiterals();
}
-
+
Review comment:
Please do not change original indent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services